Mask issues on repack

aceex7

Hi!

so when my avatar is in the pool area I turn on the attachment of the mask like so

skel.Skeleton.SetAttachment(slot, slot);

the issue happens when I change the appearance of the avatar (with different clothes) and therefore repacking the skeleton
which in turn calls the SetSlotAttachmentsToSetupPose Method
when that happens I get null on the mask's slot attachmentName

string attachmentName = slot.data.attachmentName;

so I've found a workaround by adding the lines 6-7 to the SetSlotAttachmentsToSetupPose method as follows

public static void SetSlotAttachmentsToSetupPose (this Skeleton skeleton) {
         var slotsItems = skeleton.slots.Items;
         for (int i = 0; i < skeleton.slots.Count; i++) {
            Slot slot = slotsItems[i];
            string attachmentName = slot.data.attachmentName;
          if(attachmentName == null)
               attachmentName = slot.Attachment?.Name;

        slot.Attachment = string.IsNullOrEmpty(attachmentName) ? null : skeleton.GetAttachment(i, attachmentName);
     }
  }

I can't tell if that's a bug or expected behavior and that I'm missing something?

Any help and clarifications will be appreciated

aceex7

Harald

SetAttachmentsToSetupPose or the extension method variant SetSlotAttachmentsToSetupPose (not clearing colors) unfortunately does what the name says, it sets the visible attachments to the state of the setup pose. Modifying it by adding lines 6-7 would help your case but would no longer do what the method name implies and would change its behaviour.

You can also see this in the Skeleton.SetSkin() documentation:

After changing the skin, the visible attachments can be reset to those attached in the setup pose by calling setSlotsToSetupPose. Also, often apply is called before the next time the skeleton is rendered to allow any attachment keys in the current animation(s) to hide or show attachments from the new skin.

So the intended way would be to again apply all non-setup-pose attachments after changing your skin (and potentially applying AnimationState to the skeleton again). If you would like to keep the code as-is, I would recommend simply creating a copy of the SetSlotAttachmentsToSetupPose method and rename it something like UpdateAttachmentsAfterSkinChange or whatever makes sense to you.