#Defines being removed causes Errors

BinaryCats

removing the following #defines cause compile errors:

SkeletonRenderer.cs

#define SPINE_OPTIONAL_RENDEROVERRIDE
#define SPINE_OPTIONAL_MATERIALOVERRIDE
#define SPINE_OPTIONAL_NORMALS
#define SPINE_OPTIONAL_SOLVETANGENTS

ArraysMeshGenerator.cs

#define SPINE_OPTIONAL_NORMALS

Pharan

Thanks, bcats. Should be fixed in the next unitypackage update.

27 Feb 2017 6:06 pm

Fixed.
Removing SPINE_OPTIONAL_NORMALS in ArraysMeshGenerator didn't seem to have problems though.

BinaryCats

oh we just removed all this silly stuff ( 🙂 )wasn't 100% sure what they all where

Pharan

The defines are there so people don't have to pay performance for things they don't use.

Come to think of it, normals should be off by default... since it's just better for shaders to assume uniform normals throughout the mesh.
Maybe in 3.7

BinaryCats

wait... are you saying having these defines defined (bar normals) will increase performance, we kinda assumed we would get better performance not having them :*(

Pharan

No, I mean the defines make it easy to disable them. And you should be able to disable them by doing what you did (removing the defines).
That it broke when you did that, was a bug.

BinaryCats

ohhh... its just the way you said it, kinda... never mind.

anyway, is there any other defines or things like that we can remove to increase performance?

Pharan

Not generically, no.
But if your bottleneck is having lots and lots of updating components, this may be interesting, not just for Spine code:
https://blogs.unity3d.com/2015/12/23/1k-update-calls/
Merging Update and LateUpdate

BinaryCats

we are looking into unmanaged dlls :s

28 Feb 2017, 20:20

thanks for the link